feat: support alter twcs compaction options #4965

lyang24 · 2024-11-09T22:37:12Z

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#4905

What's changed and what's your intention?

support alter twcs compaction options on sql level

The approach here is to expand ChangeOption enum with twcs compaction options.
The key and value type is validated at store-api end.
If value is missing (empty string) it will be set with default value.

Changes will be reflected on show create table statements.

How does this PR work? Need a brief introduction for the changed logic (optional)
Describe clearly one logical change and avoid lazy messages (optional)
Describe any limitations of the current code (optional)

Checklist

I have written the necessary rustdoc comments.
I have added the necessary unit tests and integration tests.
This PR requires documentation updates.

coderabbitai · 2024-11-09T22:37:18Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-11-11T05:04:14Z

Codecov Report

Attention: Patch coverage is 23.33333% with 92 lines in your changes missing coverage. Please review.

Project coverage is 83.78%. Comparing base (0e0c4fa) to head (6854d51).
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4965      +/-   ##
==========================================
- Coverage   84.07%   83.78%   -0.30%     
==========================================
  Files        1143     1144       +1     
  Lines      211918   213424    +1506     
==========================================
+ Hits       178172   178816     +644     
- Misses      33746    34608     +862

v0y4g3r

Rest LGTM

src/store-api/src/mito_engine_options.rs

src/mito2/src/worker/handle_alter.rs

tests/cases/standalone/common/alter/alter_table_options.result

src/mito2/src/worker/handle_alter.rs

src/store-api/src/region_request.rs

killme2008

LGTM. Thank you @lyang24

killme2008 · 2024-11-13T02:15:29Z

@v0y4g3r PTAL

v0y4g3r

rest LGTM

src/mito2/src/worker/handle_alter.rs

tests/cases/standalone/common/alter/alter_table_options.sql

src/table/src/metadata.rs

src/store-api/src/region_request.rs

lyang24 changed the title ~~support alter twcs compression options~~ (draft of another approach) support alter twcs compression options Nov 9, 2024

github-actions bot added the docs-not-required This change does not impact docs. label Nov 9, 2024

lyang24 closed this Nov 11, 2024

lyang24 reopened this Nov 11, 2024

lyang24 changed the title ~~(draft of another approach) support alter twcs compression options~~ feat: support alter twcs compression options Nov 11, 2024

lyang24 mentioned this pull request Nov 11, 2024

feat: support alter twcs compression options #4939

Closed

3 tasks

lyang24 marked this pull request as ready for review November 11, 2024 04:44

lyang24 requested review from v0y4g3r, evenyag, waynexia and a team as code owners November 11, 2024 04:44

lyang24 force-pushed the alter_compression2 branch from de2082e to 2476e6d Compare November 11, 2024 06:30

evenyag changed the title ~~feat: support alter twcs compression options~~ feat: support alter twcs compaction options Nov 11, 2024

v0y4g3r reviewed Nov 11, 2024

View reviewed changes

src/store-api/src/mito_engine_options.rs Outdated Show resolved Hide resolved

src/mito2/src/worker/handle_alter.rs Outdated Show resolved Hide resolved

src/mito2/src/worker/handle_alter.rs Outdated Show resolved Hide resolved

v0y4g3r reviewed Nov 11, 2024

View reviewed changes

tests/cases/standalone/common/alter/alter_table_options.result Outdated Show resolved Hide resolved

killme2008 reviewed Nov 12, 2024

View reviewed changes

src/mito2/src/worker/handle_alter.rs Outdated Show resolved Hide resolved

src/store-api/src/region_request.rs Outdated Show resolved Hide resolved

lyang24 force-pushed the alter_compression2 branch 2 times, most recently from 96113b2 to 25a494b Compare November 12, 2024 06:31

killme2008 approved these changes Nov 12, 2024

View reviewed changes

lyang24 force-pushed the alter_compression2 branch from 25a494b to 6afa707 Compare November 12, 2024 06:34

lyang24 requested a review from v0y4g3r November 12, 2024 06:35

v0y4g3r approved these changes Nov 13, 2024

View reviewed changes

src/mito2/src/worker/handle_alter.rs Outdated Show resolved Hide resolved

WenyXu reviewed Nov 13, 2024

View reviewed changes

src/mito2/src/worker/handle_alter.rs Show resolved Hide resolved

tests/cases/standalone/common/alter/alter_table_options.sql Show resolved Hide resolved

lyang24 force-pushed the alter_compression2 branch from 6afa707 to 3d192bf Compare November 13, 2024 03:43

lyang24 commented Nov 13, 2024

View reviewed changes

src/table/src/metadata.rs Show resolved Hide resolved

WenyXu reviewed Nov 13, 2024

View reviewed changes

src/table/src/metadata.rs Show resolved Hide resolved

src/store-api/src/region_request.rs Show resolved Hide resolved

support alter twcs compression options

6854d51

lyang24 force-pushed the alter_compression2 branch from 3d192bf to 6854d51 Compare November 13, 2024 04:12

WenyXu approved these changes Nov 13, 2024

View reviewed changes

v0y4g3r added this pull request to the merge queue Nov 13, 2024

WenyXu mentioned this pull request Nov 13, 2024

Add docs for altering twcs compaction options GreptimeTeam/docs#1283

Closed

Merged via the queue into GreptimeTeam:main with commit 3bbcde8 Nov 13, 2024
35 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support alter twcs compaction options #4965

feat: support alter twcs compaction options #4965

lyang24 commented Nov 9, 2024 •

edited by evenyag

Loading

coderabbitai bot commented Nov 9, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Nov 11, 2024 •

edited

Loading

v0y4g3r left a comment

killme2008 left a comment

killme2008 commented Nov 13, 2024

v0y4g3r left a comment

feat: support alter twcs compaction options #4965

feat: support alter twcs compaction options #4965

Conversation

lyang24 commented Nov 9, 2024 • edited by evenyag Loading

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Checklist

coderabbitai bot commented Nov 9, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Nov 11, 2024 • edited Loading

Codecov Report

v0y4g3r left a comment

Choose a reason for hiding this comment

killme2008 left a comment

Choose a reason for hiding this comment

killme2008 commented Nov 13, 2024

v0y4g3r left a comment

Choose a reason for hiding this comment

lyang24 commented Nov 9, 2024 •

edited by evenyag

Loading

codecov bot commented Nov 11, 2024 •

edited

Loading