feat: support parsing the RENAME TABLE statements in the parser #780

e1ijah1 · 2022-12-22T09:05:40Z

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

support parsing the RENAME TABLE statements in the parser

Checklist

I have written the necessary rustdoc comments.
I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#723

codecov · 2022-12-22T09:21:43Z

Codecov Report

Merging #780 (0614d6e) into develop (e07791c) will increase coverage by 0.06%.
The diff coverage is 81.25%.

@@             Coverage Diff             @@
##           develop     #780      +/-   ##
===========================================
+ Coverage    85.42%   85.49%   +0.06%     
===========================================
  Files          414      414              
  Lines        54230    53904     -326     
===========================================
- Hits         46328    46085     -243     
+ Misses        7902     7819      -83

Flag	Coverage Δ
rust	`85.49% <81.25%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/sql/src/statements/alter.rs	`28.57% <0.00%> (-3.01%)`	⬇️
src/sql/src/parsers/alter_parser.rs	`90.47% <84.37%> (+2.63%)`	⬆️
src/datanode/src/sql/alter.rs	`92.39% <100.00%> (+1.14%)`	⬆️
src/object-store/src/test_util.rs	`0.00% <0.00%> (-100.00%)`	⬇️
tests-integration/src/test_util.rs	`87.98% <0.00%> (-11.54%)`	⬇️
src/datanode/src/instance.rs	`32.40% <0.00%> (-11.18%)`	⬇️
src/servers/src/mysql/handler.rs	`59.84% <0.00%> (-4.55%)`	⬇️
src/datatypes/src/vectors/constant.rs	`83.20% <0.00%> (-3.06%)`	⬇️
src/servers/src/grpc.rs	`91.17% <0.00%> (-2.95%)`	⬇️
src/table/src/metadata.rs	`96.27% <0.00%> (-2.36%)`	⬇️
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

e1ijah1 · 2022-12-22T11:31:07Z

@evenyag PTAL

waynexia

Thanks @e1ijah1. Looks like there is no test covering the parser's change, do you mind adding some?

src/table/src/metadata.rs

evenyag

Let us leave the table and mito crates unchanged and add the AlterKind::RenameTable variant in the PR implementing rename table for the mito table engine. So this PR only affects the parser.

src/common/substrait/src/df_logical.rs

src/sql/src/statements/alter.rs

src/datanode/src/sql/alter.rs

src/sql/src/parsers/alter_parser.rs

src/datanode/src/sql/alter.rs

evenyag

I think it's fine to revert these changes.

src/table/src/requests.rs

src/table/src/metadata.rs

src/mito/src/table.rs

evenyag

Mostly LGTM. This should be the last suggestion 😄

src/sql/src/parsers/alter_parser.rs

Co-authored-by: Yingwen <[email protected]>

waynexia

Looks good to me ❤️

…timeTeam#780) * feat: add parsing `alter rename table` syntax to the parser * chore: fix clippy * chore: add test for parser * fix: add test for parsing RENAME keyword * chore: remove unused code * fix: parse table name object Co-authored-by: Yingwen <[email protected]> * chore: fmt code Co-authored-by: Yingwen <[email protected]>

e1ijah1 mentioned this pull request Dec 22, 2022

Tracking Issue: Supports rename table #723

Closed

5 tasks

waynexia reviewed Dec 22, 2022

View reviewed changes

src/table/src/metadata.rs Outdated Show resolved Hide resolved

evenyag reviewed Dec 22, 2022

View reviewed changes

e1ijah1 added 4 commits December 22, 2022 22:19

feat: add parsing alter rename table syntax to the parser

61ae464

chore: fix clippy

4e77ff6

chore: add test for parser

1d56332

fix: add test for parsing RENAME keyword

f745a90

e1ijah1 force-pushed the feat-rename-table-syntax branch from d424ffe to f745a90 Compare December 22, 2022 14:19

evenyag reviewed Dec 23, 2022

View reviewed changes

chore: remove unused code

530e599

e1ijah1 requested a review from evenyag December 23, 2022 06:15

evenyag reviewed Dec 26, 2022

View reviewed changes

src/sql/src/parsers/alter_parser.rs Outdated Show resolved Hide resolved

e1ijah1 and others added 2 commits December 26, 2022 15:44

fix: parse table name object

7867877

Co-authored-by: Yingwen <[email protected]>

chore: fmt code

0614d6e

waynexia approved these changes Dec 26, 2022

View reviewed changes

e1ijah1 requested a review from evenyag December 26, 2022 08:10

evenyag approved these changes Dec 27, 2022

View reviewed changes

evenyag merged commit 3978931 into GreptimeTeam:develop Dec 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support parsing the RENAME TABLE statements in the parser #780

feat: support parsing the RENAME TABLE statements in the parser #780

e1ijah1 commented Dec 22, 2022 •

edited

Loading

codecov bot commented Dec 22, 2022 •

edited

Loading

e1ijah1 commented Dec 22, 2022

waynexia left a comment

evenyag left a comment

evenyag left a comment

evenyag left a comment

waynexia left a comment

feat: support parsing the RENAME TABLE statements in the parser #780

feat: support parsing the RENAME TABLE statements in the parser #780

Conversation

e1ijah1 commented Dec 22, 2022 • edited Loading

What's changed and what's your intention?

Checklist

Refer to a related PR or issue link (optional)

codecov bot commented Dec 22, 2022 • edited Loading

Codecov Report

e1ijah1 commented Dec 22, 2022

waynexia left a comment

Choose a reason for hiding this comment

evenyag left a comment

Choose a reason for hiding this comment

evenyag left a comment

Choose a reason for hiding this comment

evenyag left a comment

Choose a reason for hiding this comment

waynexia left a comment

Choose a reason for hiding this comment

e1ijah1 commented Dec 22, 2022 •

edited

Loading

codecov bot commented Dec 22, 2022 •

edited

Loading