-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PromQL handler in query engine #861
Conversation
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #861 +/- ##
===========================================
+ Coverage 86.09% 86.36% +0.27%
===========================================
Files 421 422 +1
Lines 55549 55668 +119
===========================================
+ Hits 47823 48079 +256
+ Misses 7726 7589 -137
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Ruihang Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* example promql test Signed-off-by: Ruihang Xia <[email protected]> * make the mock test works Signed-off-by: Ruihang Xia <[email protected]> * update planner test Signed-off-by: Ruihang Xia <[email protected]> * fix clippys Signed-off-by: Ruihang Xia <[email protected]> * add license header Signed-off-by: Ruihang Xia <[email protected]> Signed-off-by: Ruihang Xia <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Implement other missing parts to make an
EvalStmt
executable by our query engine.You can get the following result by
ceil(demo{host="host1"})
(mocked) after this patch!Checklist
Refer to a related PR or issue link (optional)
#596