Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): upload sqlness log files #920

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

waynexia
Copy link
Member

Signed-off-by: Ruihang Xia [email protected]

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Background: #916 (comment)

It's hard to debug sqlness failure without those log files. This patch uploads log files after sqlness run is finished as CI artifacts. Those log files' TTL is set to 3 days, it might not be too large.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #920 (f430d5a) into develop (18e6740) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #920      +/-   ##
===========================================
- Coverage    86.18%   86.07%   -0.12%     
===========================================
  Files          430      430              
  Lines        58228    58228              
===========================================
- Hits         50185    50120      -65     
- Misses        8043     8108      +65     
Flag Coverage Δ
rust 86.07% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
src/datanode/src/instance.rs 47.11% <0.00%> (-10.67%) ⬇️
tests-integration/src/test_util.rs 79.18% <0.00%> (-9.39%) ⬇️
src/common/substrait/src/df_logical.rs 77.02% <0.00%> (-1.76%) ⬇️
src/servers/src/opentsdb.rs 96.82% <0.00%> (-1.59%) ⬇️
src/servers/src/opentsdb/codec.rs 99.11% <0.00%> (-0.45%) ⬇️
src/datatypes/src/vectors/helper.rs 66.19% <0.00%> (+0.35%) ⬆️
src/meta-srv/src/error.rs 95.34% <0.00%> (+0.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@evenyag evenyag merged commit 89e4084 into GreptimeTeam:develop Jan 31, 2023
@waynexia waynexia deleted the upload-sqlness-log branch January 31, 2023 06:32
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants