Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cray: hugepage_alloc test fails due to compiler bug #1557

Open
havogt opened this issue Sep 25, 2020 · 4 comments
Open

Cray: hugepage_alloc test fails due to compiler bug #1557

havogt opened this issue Sep 25, 2020 · 4 comments

Comments

@havogt
Copy link
Contributor

havogt commented Sep 25, 2020

test_hugepage_alloc fails on Cray clang version 10.0.2.

It's the first time we are able to use Cray without -fno-cray and it's the only failing test.

havogt added a commit that referenced this issue Sep 25, 2020
Environment changes on daint:
- CUDA is now loaded as `cudatoolkit` instead of a specific version
- Cray clang is now used without `-fno-cray`. `-fno-cray` doesn't work currently and is tracked here https://webrt.cscs.ch/Ticket/Display.html?id=40241. A Cray ticket is filed.
However, the `test_hugepage_alloc` fails, which looks like an invalid optimization, see #1557.

Performance changes:
We see quite some chagnes both on GPU and CPU after the upgrade.
Most significant:
- CUDA: vertical advection on small domain with float is about 40% slower (in all variants: clang-cuda, nvcc-clang, nvcc-gcc)
- cpu_kfirst: factor 10x slowdown for layout_transformation, maybe a vectorization issue
@havogt
Copy link
Contributor Author

havogt commented Sep 28, 2020

The wrong optimization is actually in the testing code. Allocation works properly.

@havogt
Copy link
Contributor Author

havogt commented Sep 28, 2020

@havogt
Copy link
Contributor Author

havogt commented Sep 28, 2020

The open issue after #1560 will be to re-enable the test for Cray once we have a compiler where this is fixed.

@fthaler fthaler changed the title Cray: hugepage_alloc doesn't respect offset Cray: hugepage_alloc test fails due to compiler bug Sep 29, 2020
@havogt
Copy link
Contributor Author

havogt commented Mar 24, 2021

The problem is still in Cray clang 11.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant