Skip to content

Commit

Permalink
refactor[cartesian]: Enable MaskInlining in gt4yp - DaCe bridge (#1624)
Browse files Browse the repository at this point in the history
`MaskInlining` will be a key feature of the improved gt4py / DaCe bridge
as envisioned in GEOS-ESM/NDSL#53, which will
propagate more control flow elements from gt4py to DaCe. We thus want to
make sure if `MaskInlining` itself is posing any problems. We tracked
the git history of this explicit exclude back to PR
#300, which not only added the
npir backend, but also refactored how pipeline stages are defined.
Previous to this PR optimization passes to be specified explicitly and
the PR changed this to an exclude list. It looks like the `MaskInlining`
pass was added after the list of optimization passes was formed and thus
excluded (to keep the list constant). From this history we thus don't
expect `MaskInlining` to break anything.

Co-authored-by: Roman Cattaneo <>
  • Loading branch information
romanc authored Sep 4, 2024
1 parent 829b2eb commit 07f37fb
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/gt4py/cartesian/backend/dace_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
from gt4py.cartesian.gtc.gtir_to_oir import GTIRToOIR
from gt4py.cartesian.gtc.passes.gtir_k_boundary import compute_k_boundary
from gt4py.cartesian.gtc.passes.gtir_pipeline import GtirPipeline
from gt4py.cartesian.gtc.passes.oir_optimizations.inlining import MaskInlining
from gt4py.cartesian.gtc.passes.oir_optimizations.utils import compute_fields_extents
from gt4py.cartesian.gtc.passes.oir_pipeline import DefaultPipeline
from gt4py.cartesian.utils import shash
Expand Down Expand Up @@ -353,7 +352,7 @@ def _unexpanded_sdfg(self):
except FileNotFoundError:
base_oir = GTIRToOIR().visit(self.builder.gtir)
oir_pipeline = self.builder.options.backend_opts.get(
"oir_pipeline", DefaultPipeline(skip=[MaskInlining])
"oir_pipeline", DefaultPipeline()
)
oir_node = oir_pipeline.run(base_oir)
sdfg = OirSDFGBuilder().visit(oir_node)
Expand Down

0 comments on commit 07f37fb

Please sign in to comment.