feat[next]: new domain slice syntax #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
requested changes
Feb 15, 2024
tests/next_tests/unit_tests/embedded_tests/test_nd_array_field.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Hannes Vogt <[email protected]>
Co-authored-by: Hannes Vogt <[email protected]>
Co-authored-by: Hannes Vogt <[email protected]>
Co-authored-by: Hannes Vogt <[email protected]>
havogt
requested changes
Feb 16, 2024
Co-authored-by: Hannes Vogt <[email protected]>
havogt
reviewed
Feb 22, 2024
havogt
reviewed
Feb 23, 2024
Co-authored-by: Hannes Vogt <[email protected]>
havogt
requested changes
Feb 23, 2024
src/gt4py/next/embedded/common.py
Outdated
| return new_index | ||
|
|
||
|
|
||
| def _named_slice_to_named_range(idx: common.NamedSlice) -> common.NamedRange | common.NamedSlice: |
There was a problem hiding this comment.
Suggested change
| def _named_slice_to_named_range(idx: common.NamedSlice) -> common.NamedRange | common.NamedSlice: | |
| def _named_slice_to_named_range(idx: common.NamedSlice) -> common.NamedRange: |
There was a problem hiding this comment.
Technically you could just be returning idx without any changes, so you do need common.NamedSlice in the return type
Co-authored-by: Hannes Vogt <[email protected]>
havogt
reviewed
Feb 23, 2024
havogt
reviewed
Feb 23, 2024
havogt
reviewed
Feb 23, 2024
Co-authored-by: Hannes Vogt <[email protected]>
havogt
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New domain slice syntax: f[I(-1):I(5)].
E.g. going from:
To: