Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[next]: config improvements #1461

Merged
merged 7 commits into from
Feb 26, 2024
Merged

Conversation

DropD
Copy link
Contributor

@DropD DropD commented Feb 19, 2024

Description

  • move 'next.errors.excepthook._verbose_exceptionstonext.config.VERBOSE_EXCEPTIONS`
  • merge environment flag reading mechanisms into next.config.env_flag_to_bool
  • test next.config.env_flag_to_bool
  • completely move cache._persistent_cache_dir_path to next.config.BUILD_CACHE_PATH
  • add a force_temporaries trait to GTFNBackendFactory
  • test the force_temporaries trait of GTFNBackendFactory

Requirements

  • All fixes and/or new features come with corresponding tests.
  • Important design decisions have been documented in the approriate ADR inside the docs/development/ADRs/ folder.

If this PR contains code authored by new contributors please make sure:

  • All the authors are covered by a valid contributor assignment agreement provided to ETH Zurich and signed by the employer if needed.
  • The PR contains an updated version of the AUTHORS.md file adding the names of all the new contributors.

src/gt4py/next/config.py Outdated Show resolved Hide resolved
src/gt4py/next/config.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tehrengruber tehrengruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small things.

src/gt4py/next/errors/excepthook.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/gtfn.py Outdated Show resolved Hide resolved
@DropD DropD merged commit 4228624 into GridTools:main Feb 26, 2024
31 checks passed
@DropD DropD deleted the add-config-features branch February 26, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants