feat[next][dace]: make canonical representation of field domain optional #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Baseline implementation of DaCe backend was reordering the dimensions in field domain based on alphabetical order. This is the canonical representation of field domain, and provides the advantage of not requiring regenerating the SDFG for different memory layouts of field arguments. Besides, the code for accessing a field is simple, because all field domains are assumed to follow the same layout.
However, the canonical representation poses an obstacle to the realization of module-level SDFGs, because it requires an additional conversion step of all array arguments before calling the SDFG. Therefore, we make the canonical representation optional. Note that this change should not have any performance impact, because the real memory layout of field arrays is not modified.