Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug[next]: Increase recursion limit in TraceShift pass #1482

Merged
merged 4 commits into from
Mar 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/gt4py/next/iterator/transforms/trace_shifts.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# SPDX-License-Identifier: GPL-3.0-or-later
import dataclasses
import enum
import sys
from collections.abc import Callable
from typing import Any, Final, Iterable, Literal

Expand Down Expand Up @@ -263,6 +264,8 @@ def _tuple_get(index, tuple_val):
}


# TODO(tehrengruber): This pass is unnecessarily very inefficient and easily exceeds the default
# recursion limit.
@dataclasses.dataclass(frozen=True)
class TraceShifts(PreserveLocationVisitor, NodeTranslator):
shift_recorder: ShiftRecorder = dataclasses.field(default_factory=ShiftRecorder)
Expand Down Expand Up @@ -329,16 +332,22 @@ def visit_StencilClosure(self, node: ir.StencilClosure):

result = self.visit(node.stencil, ctx=_START_CTX)(*tracers)
assert all(el is Sentinel.VALUE for el in _primitive_constituents(result))
return node

@classmethod
def apply(
cls, node: ir.StencilClosure, *, inputs_only=True, save_to_annex=False
cls, node: ir.StencilClosure | ir.FencilDefinition, *, inputs_only=True, save_to_annex=False
) -> (
dict[int, set[tuple[ir.OffsetLiteral, ...]]] | dict[str, set[tuple[ir.OffsetLiteral, ...]]]
):
old_recursionlimit = sys.getrecursionlimit()
sys.setrecursionlimit(100000000)

instance = cls()
instance.visit(node)

sys.setrecursionlimit(old_recursionlimit)

recorded_shifts = instance.shift_recorder.recorded_shifts

if save_to_annex:
Expand All @@ -348,6 +357,7 @@ def apply(
ValidateRecordedShiftsAnnex().visit(node)

if inputs_only:
assert isinstance(node, ir.StencilClosure)
inputs_shifts = {}
for inp in node.inputs:
inputs_shifts[str(inp.id)] = recorded_shifts[id(inp)]
Expand Down
Loading