-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[next]: workshop material and docs field Dims type hint update #1489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes look good to me. The only missing part is to add automatic checking of all the new notebooks (and the quickstart guide if it's not already tested) to make sure they don't go out of sync with the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, but please extend the current PR title and description to include the description of all the added changes in the commit.
edited type hints in
gt4py/docs/user/next
from e.g.:Field[[CellDim, KDim], dtype]
to:
Field[Dims[CellDim, KDim], dtype]
Addition of all workshop material under the same folder