Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[next]: workshop material and docs field Dims type hint update #1489

Merged
merged 250 commits into from
Mar 26, 2024

Conversation

nfarabullini
Copy link
Contributor

@nfarabullini nfarabullini commented Mar 13, 2024

edited type hints in gt4py/docs/user/next from e.g.:
Field[[CellDim, KDim], dtype]
to:
Field[Dims[CellDim, KDim], dtype]

Addition of all workshop material under the same folder

.gitpod.yml Outdated Show resolved Hide resolved
docs/user/next/jupyter_intro.ipynb Outdated Show resolved Hide resolved
docs/user/next/workshop/slides/slides_1.md Outdated Show resolved Hide resolved
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes look good to me. The only missing part is to add automatic checking of all the new notebooks (and the quickstart guide if it's not already tested) to make sure they don't go out of sync with the code.

Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but please extend the current PR title and description to include the description of all the added changes in the commit.

@nfarabullini nfarabullini changed the title feat[next]: docs Field type hint update feat[next]: workshop material and docs Field type hint update Mar 26, 2024
@nfarabullini nfarabullini changed the title feat[next]: workshop material and docs Field type hint update feat[next]: workshop material and docs field Dims type hint update Mar 26, 2024
@nfarabullini nfarabullini merged commit e74b5a7 into GridTools:main Mar 26, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants