refactor[next]: NamedRange/NamedIndex tuple to NamedTuple #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
changed the title
havogt
reviewed
Mar 14, 2024
havogt
reviewed
Mar 14, 2024
src/gt4py/next/common.py
Outdated
| @@ -301,15 +309,14 @@ def is_int_index(p: Any) -> TypeGuard[IntIndex]: | |||
|
|
|||
| def is_named_range(v: AnyIndexSpec) -> TypeGuard[NamedRange]: | |||
There was a problem hiding this comment.
in the end this function can be removed and replaced by just an isinstance check
Co-authored-by: Hannes Vogt <[email protected]>
havogt
changed the title
havogt
changed the title
egparedes
reviewed
Mar 20, 2024
src/gt4py/next/common.py
Outdated
| @@ -484,10 +493,10 @@ def __and__(self, other: Domain) -> Domain: | |||
| _broadcast_ranges(broadcast_dims, other.dims, other.ranges), | |||
| ) | |||
| ) | |||
| return Domain(dims=broadcast_dims, ranges=intersected_ranges) | |||
| return Domain(dims=broadcast_dims, ranges=intersected_ranges) # TODO | |||
havogt
reviewed
Mar 20, 2024
Co-authored-by: Enrique González Paredes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change NamedRange and NamedIndex from being a plain tuple to a NamedTuple for cleaner element access.