bug[next]: Fix gtfn code generation for negative literals #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
requested changes
Mar 21, 2024
| case _: | ||
| return node.value | ||
| result = node.value | ||
| if node.type in ["bool", "int32", "int64", "float32", "float64"]: |
There was a problem hiding this comment.
maybe we can just make sure that there is a space in the binary operations? 1 - -1 should be ok
BinaryExpr = as_fmt("({lhs} {op} {rhs})")
There was a problem hiding this comment.
Much nicer. Thanks.
havogt
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an extra space between the operators of BinOp such that
minus(1, -1)does not get translated into1--1, but1 - -1.While looking at that part of the code I was wondering whether there is another bug in that function namely that we don't case int32 literals to the respective C++ type.
I would add tests, but there seems to be no infrastructure for this. Should we leave it like that for now?