Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: minimize vertical space style #1518

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

egparedes
Copy link
Contributor

@egparedes egparedes commented Apr 2, 2024

Reformat with ruff-format to remove unnecessary line splitting due to automatically inserted trailing commas.
To reproduce locally, add the skip-magic-trailing-comma = true setting in the ruff configuration (in pyproject.toml, inside the [[tool.ruff.format]] table), run ruff-format, then remove the setting and run it again.

This PR is a continuation of #1517

@egparedes egparedes changed the title style: Minimize vertical space style style: minimize vertical space style Apr 2, 2024
@egparedes egparedes marked this pull request as ready for review April 2, 2024 16:11
egparedes added a commit that referenced this pull request Apr 3, 2024
)

Bump requirements' versions, update ruff format style and apply changes.

To reproduce code style changes locally, bump ruff version (either run
`tox run -e requirements-base`, which requires python3.8 or update ruff
pre-commit hook in `.pre-commit-config.yaml` to `v0.3.5`), remove
`preview = true` setting in the ruff configuration (in `pyproject.toml`,
inside the `[[tool.ruff.format]]` table) and run ruff-format.

In a following PR (#1518) the format will be changed to reduce vertical
space usage.
@egparedes egparedes force-pushed the minimize-vertical-space-style branch from 6658736 to de13b08 Compare April 3, 2024 08:31
@egparedes egparedes force-pushed the minimize-vertical-space-style branch from de13b08 to 67cbfb4 Compare April 3, 2024 08:35
@egparedes egparedes merged commit 591ea4e into GridTools:main Apr 3, 2024
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants