refactor[next]: Use is_call_to instead of equality comparison with itir.Ref. #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egparedes
reviewed
Apr 18, 2024
| >>> is_call_to(node, "plus") | ||
| False | ||
| """ | ||
| if isinstance(fun, (list, tuple, set)): |
There was a problem hiding this comment.
This isinstance() check doesn't match the typying annotation for fun.
There was a problem hiding this comment.
I switched to collections.abc.Iterable, but still included list, tuple, set for performance reasons.
| def is_if_call(node: itir.Expr) -> TypeGuard[itir.FunCall]: | ||
| """Match expression of the form `if_(cond, true_branch, false_branch)`.""" | ||
| return isinstance(node, itir.FunCall) and node.fun == im.ref("if_") | ||
| def is_call_to(node: itir.Node, fun: str | list[str]) -> TypeGuard[itir.FunCall]: |
There was a problem hiding this comment.
Just an optional suggestion, feel free to ignore: I'd like better to include the actual name of the node FunCall in its typeguard function (e.g. is_funcall_to).
There was a problem hiding this comment.
We opted for maximum convenience in the ir_makers module, e.g. im.ref also creates a SymRef so I'll keep call for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new ITIR type inference #1531 IR nodes store their type in the node itself. While we initially exclude the attribute from equality comparison we should nonetheless avoid comparison of node that only differ in type. This PR removes many of this occurrences.