Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[next][dace]: Skeleton of GTIR DaCe backend #1538

Merged
merged 84 commits into from
Jul 12, 2024

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Apr 24, 2024

We introduce a new DaCe backend that translates a GTIR program to SDFG. GTIR is still sometimes referred to as Combined-IR and provides a fieldview representation of the GT4Py program. The GT4Py frontend is not ready to lower a GT4Py program to GTIR, so for now the unit tests use manually written GTIR programs as input.

The new DaCe backend is implemented in the package gt4py.next.program_processors.runners.dace_fieldview
This package provides, for now, the method build_sdfg_from_gtir to build the DaCe SDFG.

This PR introduces translation capability for the following GTIR types:ir.Program, ir.Stmt, ir.SetAt. And for the following new builtin functions: as_field_op and select.

@edopao edopao changed the title feat[next][dace]: GTIR DaCe backend feat[next][dace]: Skeleton of GTIR DaCe backend Apr 24, 2024
@edopao edopao requested review from egparedes and havogt July 8, 2024 07:30
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the refactoring work done so far. I have some questions and suggestions to finish the work.

@edopao edopao requested a review from egparedes July 10, 2024 10:28
@edopao
Copy link
Contributor Author

edopao commented Jul 10, 2024

cscs-ci run default

Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready to go, just the final changes...

@edopao edopao requested a review from egparedes July 11, 2024 11:33
@edopao
Copy link
Contributor Author

edopao commented Jul 11, 2024

cscs-ci run default

@edopao
Copy link
Contributor Author

edopao commented Jul 12, 2024

@egparedes I have now updated the PR with the change for unique map/tasklet names, which makes debugging the SDFG transformations easier.

Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for a couple of renaming and syntactic issues, it looks good for me.

@edopao edopao requested a review from egparedes July 12, 2024 10:56
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edopao
Copy link
Contributor Author

edopao commented Jul 12, 2024

cscs-ci run default

@edopao edopao merged commit 81ccb68 into GridTools:main Jul 12, 2024
31 checks passed
@edopao edopao deleted the dace-fieldview branch July 12, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants