-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump DaCe package version #1556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run the tox action (tox r -e requirements-base
) to automatically update all the requirement files from the project metadata (see: https://github.com/GridTools/gt4py/blob/main/docs/development/tools/requirements.md)
I was waiting to do this step for the fix on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@FlorianDeconinck Do you need to run any test on PACE before I merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We will, but it shouldn't block this. We have commit-pinned versions of both gt4py and dace, we will move them with full testing on our schedule and report if anything breaks |
Btw there's another bug in Cartesian with unused scalar we found, which this PR doesn't solve. Frank Malentino from NOAA has the specifics if anyone is interested. |
Upgrade DaCe package version to release v0.16.1. Include GT4Py-next code changes enabled by bugfixes included in the new DaCe package.
Package versions updated in requirement files, but keeping
nanobind==1.9.2
(GT4Py does not support v2.0.0) andmypy==1.10.0
(v1.10.1 not available for pre-commit).A couple of code changes in GT4Py-cartesian DaCe backend: