Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump DaCe package version #1556

Merged
merged 15 commits into from
Jun 26, 2024
Merged

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Jun 14, 2024

Upgrade DaCe package version to release v0.16.1. Include GT4Py-next code changes enabled by bugfixes included in the new DaCe package.

Package versions updated in requirement files, but keeping nanobind==1.9.2 (GT4Py does not support v2.0.0) and mypy==1.10.0 (v1.10.1 not available for pre-commit).

A couple of code changes in GT4Py-cartesian DaCe backend:

  • temporary config in test case to force serialize all fields in SDFG JSON representation, because the default config value was chaged in the new dace release
  • handle scalar parameters in stencil objects as scalars rather than symbols, to avoid undefined symbol issues when the parameter is not used

@egparedes egparedes changed the title build[cartesian][next]: Bump DaCe package version build: bump DaCe package version Jun 25, 2024
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the tox action (tox r -e requirements-base) to automatically update all the requirement files from the project metadata (see: https://github.com/GridTools/gt4py/blob/main/docs/development/tools/requirements.md)

@edopao
Copy link
Contributor Author

edopao commented Jun 25, 2024

Please run the tox action (tox r -e requirements-base) to automatically update all the requirement files from the project metadata (see: https://github.com/GridTools/gt4py/blob/main/docs/development/tools/requirements.md)

I was waiting to do this step for the fix on nanobind version. Anyway, I have updated the requirement files now but I manually force nanobind==1.9.2

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@edopao edopao requested a review from egparedes June 25, 2024 11:44
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edopao
Copy link
Contributor Author

edopao commented Jun 26, 2024

@FlorianDeconinck Do you need to run any test on PACE before I merge this PR?

Copy link
Contributor

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianDeconinck
Copy link
Contributor

@FlorianDeconinck Do you need to run any test on PACE before I merge this PR?

We will, but it shouldn't block this. We have commit-pinned versions of both gt4py and dace, we will move them with full testing on our schedule and report if anything breaks

@FlorianDeconinck
Copy link
Contributor

Btw there's another bug in Cartesian with unused scalar we found, which this PR doesn't solve. Frank Malentino from NOAA has the specifics if anyone is interested.

@edopao edopao merged commit b8f7f72 into GridTools:main Jun 26, 2024
55 checks passed
@edopao edopao deleted the dace-bump_version branch June 26, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants