Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[next][dace]: GTIR-to-SDFG lowering of cast_ builtin #1610

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Aug 9, 2024

Add support to lower GTIR like:
y @ c⟨ IDimₕ: [0, size) ⟩ ← as_fieldop(λ(a) → cast_(·a, float64), c⟨ IDimₕ: [0, size) ⟩)(x);

Test case added.

@edopao edopao requested a review from havogt August 12, 2024 05:57
@edopao edopao requested a review from havogt August 13, 2024 15:20
@edopao edopao requested a review from havogt August 14, 2024 07:01
Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you intentionally remove the copy test?

@edopao
Copy link
Contributor Author

edopao commented Aug 14, 2024

did you intentionally remove the copy test?

Yes, the test was not useful because it used as_fieldop to do element-wise copy of the field. Besides, in #1609 I will introduce another kind of copy test which covers an interesting corner case of lowering to SDFG.

@edopao edopao merged commit db6a88c into GridTools:main Aug 14, 2024
31 checks passed
@edopao edopao deleted the dace-astype branch August 14, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants