Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixed typos in ADRs and a docstring #1627

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

romanc
Copy link
Contributor

@romanc romanc commented Sep 3, 2024

I noticed a couple of typos in the ADRs (and in one docstring) while I was familiarizing myself with the codebase. Thanks for keeping an ADR and good documentation practices. Really helps if you are new to a codebase.

This PR just fixes mentioned typos.

@romanc
Copy link
Contributor Author

romanc commented Sep 3, 2024

I can't seem to add reviewers from the Github UI. @havogt would you mind having a quick look and kicking off the CI? Thanks! 🙏

@egparedes
Copy link
Contributor

cscs-ci run

Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@egparedes egparedes merged commit 829b2eb into GridTools:main Sep 4, 2024
35 checks passed
@romanc romanc deleted the romanc/typos-in-adrs branch September 4, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants