Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[next][dace]: Build clean nestedSDFG without unused data connectors #1628

Merged
merged 1 commit into from
Sep 4, 2024
Merged

feat[next][dace]: Build clean nestedSDFG without unused data connectors #1628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_sdfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
from typing import Any, Dict, List, Optional, Protocol, Sequence, Set, Tuple, Union

import dace
import dace.transformation.dataflow as dace_dataflow

from gt4py import eve
from gt4py.eve import concepts
Expand Down Expand Up @@ -395,13 +394,21 @@ def visit_Lambda(
lambda_symbols = self.global_symbols | {
pname: type_ for pname, (_, type_) in lambda_args_mapping.items()
}
# obtain the set of symbols that are used in the lambda node and all its child nodes
used_symbols = {str(sym.id) for sym in eve.walk_values(node).if_isinstance(gtir.SymRef)}

nsdfg = dace.SDFG(f"{sdfg.label}_nested")
nstate = nsdfg.add_state("lambda")

# add sdfg storage for the symbols that need to be passed as input parameters,
# that is only the symbols that are used in the context of the lambda node
self._add_sdfg_params(
nsdfg,
[gtir.Sym(id=p_name, type=p_type) for p_name, p_type in lambda_symbols.items()],
[
gtir.Sym(id=p_name, type=p_type)
for p_name, p_type in lambda_symbols.items()
if p_name in used_symbols
],
)

lambda_nodes = GTIRToSDFG(self.offset_provider, lambda_symbols.copy()).visit(
Expand Down Expand Up @@ -527,9 +534,5 @@ def build_sdfg_from_gtir(
sdfg = sdfg_genenerator.visit(program)
assert isinstance(sdfg, dace.SDFG)

# nested-SDFGs for let-lambda may contain unused symbols, in which case
# we can remove unnecesssary data connectors (not done by dace simplify pass)
sdfg.apply_transformations_repeated(dace_dataflow.PruneConnectors)

sdfg.simplify()
return sdfg
Loading