style: Remove stale references to isort #1631
Conversation
isort has been replaced by ruff with PR GridTools#1466. Removing isort means rebuilding the requirements, which updates a couple of unrelated (to the isort removal) dependencies.
romanc
changed the title
|
/cc @egparedes I found more leftovers from the |
| @@ -12,7 +12,7 @@ | |||
| import pytest | |||
|
|
|||
|
|
|||
| pytest.importorskip("atlas4py") # isort: skip | |||
| pytest.importorskip("atlas4py") | |||
There was a problem hiding this comment.
I'm a bit surprised this is not longer needed, but it's good to know. Also note that the #isort: skip comments are actually respected by ruff (https://docs.astral.sh/ruff/linter/#action-comments) although it would have been better to add the # ruff: prefix as it is mentioned in the docs.
There was a problem hiding this comment.
I was also surprised that nothing breaks, but since it works at is, I think it's better to remove them. Good to know (for the future) that ruff respects these.
|
cscs-ci run |
Do I read the logs correctly and the two tests just failed because there weren't any nodes responding (to slurm) in the 8h time window? Or do you think it is stuck somewhere in setup (given that I changed dependencies)? |
No, I think you're right and failure is unrelated to the changes in this PR. Let's try again. |
|
cscs-ci run |
Description
isorthas been replaced byruffin PR #1466.Note Removing
isortmeans rebuilding the requirements, which updates a couple of unrelated (to theisortremoval) dependencies.Note 2 I also checked for
black(formatter) and there are lingering references too. However,blackis actively used as formatter in code generationgt4py/src/gt4py/eve/codegen.py
Line 106 in 70dd7c3
Requirements
If this PR contains code authored by new contributors please make sure:
AUTHORS.mdfile adding the names of all the new contributors.