Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug[next]: Fix implicit offset provider #1638

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

tehrengruber
Copy link
Contributor

#1484 introduced support for writing field(I+1). The implicit offset providers we generate for this accidentally also included local dimensions, which broke e.g. Icon4Py with errors like:

                    if not dim.kind == common.DimensionKind.VERTICAL:
>                       raise ValueError(
                            "Mapping an offset to a horizontal dimension in unstructured is not allowed."
                        )
E                       ValueError: Mapping an offset to a horizontal dimension in unstructured is not allowed.

This PR fixes that by only including horizontal and vertical, but not local dimensions in the implicit offset providers.

Copy link
Contributor

@SF-N SF-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me.

@tehrengruber tehrengruber merged commit cd20826 into GridTools:main Sep 11, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants