bug[next]: fix lowering of astype on tuples containing scalars
#1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehrengruber
approved these changes
Sep 16, 2024
| @@ -102,6 +102,7 @@ def process_elements( | |||
| process_func: Callable[..., itir.Expr], | |||
| objs: itir.Expr | Iterable[itir.Expr], | |||
| current_el_type: ts.TypeSpec, | |||
| with_type: bool = False, | |||
There was a problem hiding this comment.
Update to the docstring is missing.
Co-authored-by: Till Ehrengruber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unpacked tuple will contain
as_fieldopedcast_s for fields, but directcast_s for scalars.Note: A similar change is not needed for
wherewhich also works on tuples in thetrueandfalsebranches. The reason is thatmaskis required to be aField, thereforetrueandfalseare promoted toFields, too.