feat[dace]: Modified gt_simplify()
#1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the pass was just calling the native DaCe version. Now it will not call the `PromoteScalarToSymbol` and `ConstantPropagation` pass. This is because the lowering sometimes has to change between a symbol and a scalar and back and back angain and so on. Furthermore, it looks like these passes have problems with that, so we excluded them. This is a temporary solution, at the end, it might be feasable or good to run the full simplify pass.
edopao
reviewed
Sep 18, 2024
src/gt4py/next/program_processors/runners/dace_fieldview/transformations/auto_opt.py
Outdated
Show resolved
Hide resolved
Thus if `skip` is `None` or empty, then the full DaCe pass will be run. Futhermore, the argument now accepts an iterable, for correctness we have to turn it into a `set` though.
edopao
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the pass was just calling the native DaCe version. Now it will not call the
PromoteScalarToSymbolandConstantPropagationpass. This is because the lowering sometimes has to change between a symbol and a scalar and back and back again and so on. Furthermore, it looks like these passes have problems with that, so we excluded them.This is a temporary solution, at the end, it might be feasible or good to run the full simplify pass.