feat[dace]: Custom SDFG inline pass #1649
Conversation
| Args: | ||
| sdfg: The SDFG to optimize. | ||
| validate: Perform validation after the pass has run. | ||
| validate_all: Perform extensive validation. | ||
| skip: List of simplify passes that should not be applied, defaults | ||
| to `GT_SIMPLIFY_DEFAULT_SKIP_SET`. | ||
| """ | ||
| return dace_passes_simplify.SimplifyPass( | ||
| if skip is None: |
There was a problem hiding this comment.
Probably we should remove the Optional type, because anyway we have a default skip set. If instead we have to keep Optional, and I see then the need for this if-statement, then we can also move back the default set here.
There was a problem hiding this comment.
I see your point, but keeping optional would allow for skip=None to tell the transformation to not skip anything.
Otherwise we would have to write skip=[] or skip=set() which is more cryptic. But I removed it, what do you think?
@edopao
There was a problem hiding this comment.
I am OK with that, both options are OK. My only comment is that if we keep Optional, it makes more sense (I think) to have None as default and go back to the old way of initializing the set.
There was a problem hiding this comment.
@edopao I made the changes we discussed.
src/gt4py/next/program_processors/runners/dace_fieldview/transformations/auto_opt.py
Show resolved
Hide resolved
|
LGTM |
Added a custom pass for inlining SDFG.
The function builds upon the traditional inline pass (
InlineSDFG), however, before it is run some cleaning steps are preformed (PruneConectorsandPruneSymbols) which increase the likelihood that the inlining can be done.The cost is that state fusing is performed.
Also the
gt_simplify()function is modified, instead of the build in behaviour it will only run the GT4Py specific one.This behaviour can not be changed.