functional: refactor common types utils into separate module #666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The utilities in the FOAST type deduction are independent of the FOAST and only require the symbol types in
ffront.common_types
. This PR refactors them into a separate module so that I can use them in thePAST
type deduction.Note that the mypy version that we are currently using does not support pythons
match
statement used in the code. As such mypy fails and according to python/mypy#11829 there doesn't seem to be a way to suppress the warning. Support is expected to land in the next release 0.940 and is already on master: python/mypy#10191