Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loving this scrollbar, just wish there was a scrollbarMaxSize option #125

Closed
noir1899 opened this issue Nov 29, 2017 · 1 comment
Closed

Comments

@noir1899
Copy link

noir1899 commented Nov 29, 2017

Please mark this as an enhancement request and not a bug report. I was looking for custom scrollbar script that would be unobtrusive and lightweight, and this one is perfect. I have no complaints.

I do think having a "scrollbarMaxSize" option would be a worthwhile inclusion, to complement the "scrollbarMinSize" option that already exists.

It might be subjective, but having a tall thumb (the moveable part of the scrollbar) on a short page element can look kind of silly in some instances. In my case the scrollbar thumb is almost the full height of the element. I realize this is probably how most modern touch devices would display their scroll indicators as well, but it's one aspect of this script that I wanted to customize, and was unable to do so via CSS.

To clarify: I can set the max-height of the scrollbar element to achieve the desired result visually, but functionally, once I scroll this bar down by half a centimeter it reaches the bottom of its track, rather than scrolling to the bottom of the element as normal.

Just thought I'd make the suggestion. If you don't think it's worth including, I understand.

Thanks again for making this plugin.

PS: One last thing to add. I was also confused at first by the double-scrollbar issue others have experienced. I guess I thought because the documentation states that it hides the native scrollbar, I should have "overflow:auto;" in my CSS. It might be good to include a brief explanation somewhere in the doc that this is, in fact, the incorrect way to use simplebar. At least it would help future numbskulls like myself! :)

@Grsmto
Copy link
Owner

Grsmto commented Mar 14, 2018

Hi @noir1899 sorry for the late reply and thanks very much for your suggestions.
I think this may fit in the script if this is simple to implement, I'll look into it.

@Grsmto Grsmto closed this as completed in 741b48b Apr 8, 2018
Grsmto pushed a commit that referenced this issue Apr 9, 2018
* master:
  Add an scrollMaxSize option (fix #125
  Refactor the way options are retrieved to be more scalable (no more mapping from data attributes)
  Direction option is now handled through options for performances reason (ref #162)
  Fix RTL support not positioning scrollbar properly (fix #153)
  Add a "caveats" section to the README (fix #91)
  2.6.1
  Remove !important rule on props that don't absolutely need it
  Overflow css rules shouldn't be defined as !important so user can opt-out from x/y scroll by overriding these easily
  Add a new option to force track to be visible (same behaviour as overflow: scroll, show track, hide scrollbar) (ref #129)
  Set SimpleBar to inherit from parent's max-height + fix issue in IE11 (fix #154)
  add dist files for 2.6.0
  2.6.0

# Conflicts:
#	dist/simplebar.css
#	dist/simplebar.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants