Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match on ES6-style module keywords. #9

Merged
merged 1 commit into from
Mar 2, 2017

Conversation

schneidmaster
Copy link
Contributor

What: Adds matching for ES6 keywords (import, export, etc) which are officially supported in CoffeeScript as of 1.11.0.

Before:
screenshot 2017-03-01 20 44 16

After:
screenshot 2017-03-01 20 44 04

Why: Improves readability when using ES6 keywords. Closes #6

Testing: Check out branch, copy syntax/CJSX.sublime-syntax to your Sublime Text packages folder, open a CJSX file in Sublime, and use the command palette to select the new syntax.

@cooncesean cooncesean merged commit 0baea06 into Guidebook:master Mar 2, 2017
@cooncesean
Copy link
Contributor

@schneidmaster lemme know when you've finished making tweaks to get this up to speed w/ Sublime 3 and we'll cut a new release and open a PR to the sublime package mgr repo.

@schneidmaster
Copy link
Contributor Author

@cooncesean That's all the tweaks I'd planned on making for the time being -- just wanted to clean things up a bit & add some ES6 support. Happy to help fix any other bugs/issues as they spring up.

@schneidmaster schneidmaster deleted the es6-keywords branch March 2, 2017 16:03
@schneidmaster
Copy link
Contributor Author

Hey @cooncesean -- do you mind cutting a release and updating package control? I don't have any other PRs to send your way so it'd be nice to get the fixes/improvements out 🙂

@cooncesean
Copy link
Contributor

@schneidmaster currently OOO for the next 7 days. Apologies for not cutting something sooner.

@kwood if you (or someone else in the group) has bandwidth this weekend, would it be possible to get something out for Zach?

@schneidmaster
Copy link
Contributor Author

No rush at all! Enjoy your time away :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants