-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JdtVisitor ignores optionalTagName for javadocs #355
Comments
@pouryafard75 getTagName So, this a property of the
We should update the Visitor to generate the tree as shown above. The |
Hello @pouryafard75 and @tsantalis ! Thanks a lot for the detailed bug report. I tend to agree with @tsantalis it should be a separate child of a Cheers! |
@pouryafard75 @jrfaller |
@tsantalis sure! |
@tsantalis @jrfaller
|
I am using the following code snipet to test (in case you want to examine the offsets on your own)
|
@pouryafard75 |
@tsantalis Yes, I tried to be consistent with the codebase. |
Hi all! Uppercase is for types that are not directly converted from the JDT AST therefore it's perfect for this case! @pouryafard75 I think the structure is good! |
@jrfaller You can close this issue. |
Hello,
I just realized JdtVisitor ignores the
optionalTagName
while visitingTagElement
.Code:
Generated tree:
author is not part of the generated tree.
Since Eclipse JDT, reports this as the
optionalTagName
, I assume there's no need to create a seperate node for it.However, it's still possible to concatenate it with the
TextElement
that comes after and generate the following:You can find my implementation here. This is a very naive implementation, and I am not sure if this covers all the cases. If
TagElement
can contain multipleTextElement
, it will be problematic. Also, it assumes, that there will be always aTextElement
as a child which comes after.@tsantalis Are there any other possible scenarios?
@jrfaller Please share your thoughts.
The text was updated successfully, but these errors were encountered: