fix: address some lint violations (#219)

Gusto · Feb 21, 2023 · dcd11e9 · dcd11e9
1 parent c7b987d
commit dcd11e9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -49,7 +49,7 @@ Metrics/ParameterLists:
   Max: 5
   CountKeywordArgs: false
 Metrics/LineLength:
-  Max: 100
+  Max: 120
   Exclude:
     - lib/apollo-federation/tracing/proto/apollo_pb.rb
 

diff --git a/lib/apollo-federation/schema.rb b/lib/apollo-federation/schema.rb
@@ -12,7 +12,7 @@ def self.included(klass)
     end
 
     module CommonMethods
-      DEFAULT_LINK_NAMESPACE = 'federation'.freeze
+      DEFAULT_LINK_NAMESPACE = 'federation'
 
       def federation(version: '1.0', link: {})
         @federation_version = version

diff --git a/spec/apollo-federation/schema_spec.rb b/spec/apollo-federation/schema_spec.rb
@@ -14,7 +14,7 @@
       expect(schema.federation_version).to eq('1.0')
     end
 
-    it 'returns the specified version when set' do
+    it 'returns the specified version when set to 2.0' do
       schema = Class.new(GraphQL::Schema) do
         include ApolloFederation::Schema
         federation version: '2.0'
@@ -23,7 +23,7 @@
       expect(schema.federation_version).to eq('2.0')
     end
 
-    it 'returns the specified version when set' do
+    it 'returns the specified version when set to 2.3' do
       schema = Class.new(GraphQL::Schema) do
         include ApolloFederation::Schema
         federation version: '2.3'
@@ -88,7 +88,7 @@
       expect(schema.federation_2?).to be(true)
     end
 
-    it 'returns true when the version is a string greater than 2.0' do
+    it 'returns true when the version is a string equal to 2.3' do
       schema = Class.new(GraphQL::Schema) do
         include ApolloFederation::Schema
         federation version: '2.3'