Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Respect Federation version in @link directive #222

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lyricsboy
Copy link

@lyricsboy lyricsboy commented Feb 23, 2023

Problem

The federation version, though specifiable in the schema configuration, was not reflected in the @link directive URL when output via the federation_sdl method.

Solution

Use the federation_version as specified when building the URL.

@lyricsboy lyricsboy force-pushed the fix/respect-federation-version-in-link-directive branch from 0e717ea to e5eb20f Compare February 23, 2023 21:21
@lyricsboy lyricsboy changed the title Respect Federation version in @link directive fix: Respect Federation version in @link directive Feb 23, 2023
@lyricsboy lyricsboy marked this pull request as ready for review February 23, 2023 21:49
@dzmitry-miadzvedzeu
Copy link

Hello Everyone.

I want to clarify the status of this PR, if this change is considered a "breaking change", and hence, not possible to merge right now (reference to #267)?

Thank you in advance for your time and assistance.

@Kaytal
Copy link

Kaytal commented Sep 30, 2024

I know it's been a while since this PR was originally opened. However, I second this PR. It shouldn't be considered a breaking change any more than defining your federation version: 2.1 and getting a @link spec that matches federation 2.3. Additionally, locking the specification to 2.3 prevents many additional improvements and directives on later versions of Apollo Federation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants