Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote image length warnings using requests instead of urllib (standard lib) #289

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Jun 11, 2024

Related to #257

@github-actions github-actions bot added bug Something isn't working dependencies Pull requests that update a dependency file labels Jun 11, 2024
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.97%. Comparing base (7e51e12) to head (b4cfa0f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   83.94%   83.97%   +0.02%     
==========================================
  Files           9        9              
  Lines         542      543       +1     
  Branches      114      114              
==========================================
+ Hits          455      456       +1     
  Misses         56       56              
  Partials       31       31              
Flag Coverage Δ
unittests 83.97% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
mkdocs_rss_plugin/util.py 74.28% <100.00%> (+0.10%) ⬆️

@Guts Guts merged commit 6e0e6eb into main Jun 14, 2024
9 checks passed
@Guts Guts deleted the fix/remote-image-length-warnings branch June 14, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant