-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added LeafValueEditor interface to MaterialTimePicker #234
Open
marcrh
wants to merge
270
commits into
GwtMaterialDesign:release_2.1
Choose a base branch
from
marcrh:master
base: release_2.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks will add this to 2.1 |
kevzlou7979
reviewed
Jul 28, 2018
import com.google.gwt.dom.client.Document; | ||
import com.google.gwt.dom.client.Style; | ||
import com.google.gwt.editor.client.LeafValueEditor; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, is this incomplete?
Allows for generic String referencing using the KeyFactory
…gwt-material-addins into release_2.1.1 # Conflicts: # src/main/java/gwt/material/design/addins/client/combobox/MaterialComboBox.java
…se_2.1.1 Release 2.1.1
…k, refactored callback to dataCallback
- JsAvatar, JsCarousel, JsCircularProgress, JsInputMaskOptions, JsLiveStamp,
… also this will avoid individual JDT process each tests.
…he widget is attached.
…first before initializing the dnd area.
…se_2.4.0 Release 2.4.0
…instead of valuebox.setAutocomplete(true | false) because of browser new policies.
…se_2.4.0 Release 2.4.0-rc2
…se_2.4.0 Official 2.4.0 Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added LeafValueEditor interface to MaterialTimePicker to integrate with the Editor structures and fixed the setOrientation function.