Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker disappears on Chrome version 73 #901

Closed
mbudnick opened this issue Mar 22, 2019 · 20 comments
Closed

DatePicker disappears on Chrome version 73 #901

mbudnick opened this issue Mar 22, 2019 · 20 comments

Comments

@mbudnick
Copy link
Contributor

If you click down with Chrome Version 73 in an inputfield with datePicker the overlay appear.
If you release the klick the overlay disappear.
If you then change into an other tab and came back the overlay is visible once again and you can use the datePicker.

@fzamagni
Copy link

Goodmorning.
I confirm the bug: I have just updated Chrome to version 73 and the bug appears.
For me doesn't work changing tab and come back: MaterialDatePicker doesn't work ever.
Same Issue on MaterialTimePicker.

We use Java 7 and GMD 1.6.2, but I have the same issue on demo sites of GMD 2.1.1 and 2.2.

@kevin-i3
Copy link

Thanks for the catch, will be having a bug fixing session as soon as possible.

@burl21
Copy link

burl21 commented Mar 28, 2019

I noticed that when the click is over the placeholder(label) the modal do not close, works correctly.

@washowasho
Copy link

This also applies to the TimePicker as well.

@Shogikishi
Copy link

Thanks for the catch, will be having a bug fixing session as soon as possible.

Any updates on this issue?

@h3r3t1c
Copy link

h3r3t1c commented Apr 2, 2019

Here is my quick fix to get the date picker dialog to open:

MaterialDatePicker mDatePicker = new MaterialDatePicker(){

	@Override
	protected void onLoad() {
		super.onLoad();
		final MaterialDatePicker dp = this;
		this.getElement().getStyle().setPosition(Position.RELATIVE);
		MaterialPanel p = new MaterialPanel();
		p.getElement().getStyle().setPosition(Position.ABSOLUTE);
		p.getElement().getStyle().setZIndex(100);
		p.setHeight("50px");
		p.setWidth("100%");
		p.getElement().getStyle().setTop(0, Unit.PX);
		p.getElement().getStyle().setCursor(Cursor.POINTER);
		p.addClickHandler(new ClickHandler() {

			@Override
			public void onClick(ClickEvent event) {
				dp.open();
			}});
		this.add(p);
	}
	
};

This also works with MaterialTimePicker.

@kevin-i3
Copy link

kevin-i3 commented Apr 3, 2019

Tested the old showcase and new one, I think there was an issue with the new Chrome 73. Will be applying a patch today and release a snapshot 2.2 tomorrow early

@kevin-i3
Copy link

kevin-i3 commented Apr 3, 2019

Related issue amsul/pickadate.js#1138 - amsul/pickadate.js@82900d6

@kevzlou7979
Copy link
Contributor

https://bugs.chromium.org/p/chromium/issues/detail?id=941910

@kevin-i3
Copy link

kevin-i3 commented Apr 4, 2019

https://stackoverflow.com/questions/55147819/chrome-update-73-materialize-css-js-trigger-error

@kevin-i3
Copy link

kevin-i3 commented Apr 4, 2019

Tested also on time picker. reference Dogfalo/materialize#6312

@washowasho
Copy link

Is the 2.2-SNAPSHOT on the Maven Central repo? Or is it somewhere else?

@kevin-i3
Copy link

kevin-i3 commented Apr 4, 2019

Just pushing the changes, 2.2-SNAPSHOT was on Maven Central.

@kevin-i3
Copy link

kevin-i3 commented Apr 4, 2019

DatePicker has been updated and resolved the issue on 2.2-SNAPSHOT

@kevin-i3
Copy link

kevin-i3 commented Apr 4, 2019

dp-tp-updates

Ok Timepicker and DatePicker has been fully patched on 2.2-SNAPSHOT. Check them out.

@washowasho
Copy link

I'm looking here, and I don't see it. Am I looking in the wrong spot?

http://central.maven.org/maven2/com/github/gwtmaterialdesign/gwt-material/

@kevzlou7979
Copy link
Contributor

@kevzlou7979
Copy link
Contributor

If you are using maven then it will auto-download the update, if jar then you need to download it directly from the link I've shared

@washowasho
Copy link

Got it. That was exactly it,... my Maven wasn't tied to the repository. Thanks man.

  <repository>
        <id>oss-sonatype</id>
        <name>oss-sonatype</name>
        <url>https://oss.sonatype.org/content/repositories/snapshots/</url>
        <snapshots>
            <enabled>true</enabled>
        </snapshots>
  </repository>

@chamgda
Copy link

chamgda commented Jul 4, 2019

This issue is only partially fixed in the version deployed on https://gwtmaterialdesign.github.io/gmd-core-demo/#datePicker. If you do not release the mouse button immediately when clicking anywhere else but the label of the datepicker, the behaviour is just like before.
Interestingly when clicking on the label, the datepicker is only opened on mouse-up and stays open, when you click on the input, the datepicker is opened on mouse-down and closes on mouse-up if you don't release the mouse button immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants