Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #83 #1

Merged
merged 3 commits into from
Jun 10, 2024
Merged

fix #83 #1

merged 3 commits into from
Jun 10, 2024

Conversation

GyeongHoKim
Copy link
Owner

Description

node.js that using RTSPClient crashes when ECONNRESET of RTSPServer because it does not handles that error.
fixed RTSPClient.ts

  1. emit "error" event to handle errors after connection(including ECONNRESET
  2. emit "close" event when RTSPClient closes its connection for better debugging

if this pull request merges, users can handle ECONNRESET by

const client = new RTSPClient(username, password);
client.on("error", () => { // reconnect or something });

Related Issue

Fixes mbullington#83

 - listen and emit error that occurs when network error or unexpected RTP server errors
 - for example it handles ECONNRESET
@GyeongHoKim GyeongHoKim merged commit 53f6e9c into master Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTSP server crashing causes node to crash as well
1 participant