Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync 1.14 branch with develop #3887

Merged
merged 49 commits into from
Dec 7, 2023
Merged

Conversation

jhendersonHDF
Copy link
Collaborator

Synchronize 1.14 branch with changes in develop after commit ea1714b

vchoi-hdfgroup and others added 30 commits December 6, 2023 20:21
* Fix for issue HDFGroup#3025: Save the MPI info in the file struct so H5Fget_access_plist() can retrieve it from there.
When opening a file with the core VFD and a file image, if the file
already exists, the file check would leak the POSIX file handle.

Fixes GitHub issue HDFGroup#635
* Cancel running GitHub workflows on push to same PR

* Remove github.sha from workflow concurrency groups
Avoids overly verbose output from all processes emitting progress, etc. info.
…Group#3786)

The parallel compression test code tests for the case where all MPI ranks have no selection in a dataset when writing to it. Add an early exit to the code to avoid attempting to use a NULL pointer due to there being no work to do.
* H5FD_CURR_SPLITTER_VFD_CONFIG_VERSION
* H5FD_SPLITTER_PATH_MAX
* H5FD_SPLITTER_MAGIC
* H5FD_splitter_vfd_config_t
* H5Pset_fapl_splitter()
* H5Pget_fapl_splitter()
* Add Doxygen for all H5FD_<VFD> initializers
* Add Doxygen for all H5FD_<VFD>_VALUE values
* Mark H5FD_<vfd>_init() calls private in Doxygen
* Disable testing as tests are failing the same as in CMake
* Set NVHPC maximum optimization level to -O1 for now

Compiling HDF5 with NVHPC 23.5 - 23.9 results in test failures in
4 different test files that need to be resolved. Since those tests
pass with an optimization level of -O1 (and -O0) and it is currently
unclear whether the test failures are due to issues in HDF5 or issues
in the 'nvc' compiler, set the maximum optimization level for NVHPC
to -O1 until the test failures are resolved.

* Disable nvhpc Java testing in CMake and amend known issues

* Re-enable testing of Autotools nvhpc
* fix seg fault on frontier/cray

* fix seg fault on frontier/cray

* fix seg fault on frontier/cray

* removed the use of h5pclose_c

* removed the use of h5pclose_c
…ddress_f (HDFGroup#3801)

* Added H5VLnative_addr_to_token_f and H5VLnative_token_to_address_f

* Added H5VLnative_addr_to_token_f and H5VLnative_token_to_address_f tests
* Create test and add to testphdf5
* provide an alternative to mapfile for older bash
The H5T floating-point datatype initialization code can raise exceptions when handling signaling NaNs. This change disables FE_INVALID exceptions during initialization.

Also removes the -ieee=full change for NAG Fortran as that shouldn't be necessary anymore.

Fixes HDFGroup#3831
@jhendersonHDF jhendersonHDF added Component - Documentation Doxygen, markdown, etc. Component - Java Java wrappers Component - Fortran Fortran wrappers Component - C++ C++ wrappers Component - Parallel Parallel HDF5 (NOT thread-safety) Component - Testing Code in test or testpar directories, GitHub workflows Component - Build CMake, Autotools Type - Task Actions that don't fit into any other type category Branch - 1.14 PRs to hdf5_1_14 Component - Misc Anything else (CODEOWNERS, etc.) labels Dec 7, 2023
@jhendersonHDF
Copy link
Collaborator Author

Please let me know if there are any changes that should not be in this PR. Due to their size, I have left out the commits for 28d2b67 "HDF5 API test updates" and fc88fcd "Develop merge examples" / ac650fa "Update examples with 1.6 api and static libs". These will be merged separately and individually after this PR is merged.

@@ -151,12 +163,18 @@
COMMAND ${CMAKE_CROSSCOMPILING_EMULATOR} $<TARGET_FILE:h5copy${tgt_file_ext}> -i ./testfiles/${infile} -o ./testfiles/${testname}.out.h5 -v -s ${psparam} -d ${pdparam}
)
set_tests_properties (H5COPY-${testname}-prefill PROPERTIES DEPENDS H5COPY-${testname}-clear-objects)
if ("" MATCHES "${HDF5_DISABLE_TESTS_REGEX}")
Copy link
Contributor

@byrnHDF byrnHDF Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix this in develop.
S.B.
set_tests_properties (H5COPY-${testname}-prefill PROPERTIES DEPENDS H5COPY-${testname}-clear-objects)
if ("H5COPY-${testname}-prefill" MATCHES "${HDF5_DISABLE_TESTS_REGEX}")
set_tests_properties (H5COPY-${testname}-prefill PROPERTIES DISABLED true)
endif ()

Copy link
Contributor

@byrnHDF byrnHDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI, CMake, Tools good. Except for fix needed in h5copy in develop.

src/H5Tinit_float.c Outdated Show resolved Hide resolved
@lrknox lrknox merged commit fb84c69 into HDFGroup:hdf5_1_14 Dec 7, 2023
45 checks passed
@jhendersonHDF jhendersonHDF deleted the 1_14_dev_sync branch December 8, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch - 1.14 PRs to hdf5_1_14 Component - Build CMake, Autotools Component - C Library Core C library issues (usually in the src directory) Component - C++ C++ wrappers Component - Documentation Doxygen, markdown, etc. Component - Fortran Fortran wrappers Component - High-Level Library Code in the hl directory Component - Java Java wrappers Component - Misc Anything else (CODEOWNERS, etc.) Component - Parallel Parallel HDF5 (NOT thread-safety) Component - Testing Code in test or testpar directories, GitHub workflows Component - Tools Command-line tools like h5dump, includes high-level tools Merge Use this label when a PR is for a downstream merge Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Task Actions that don't fit into any other type category
Projects
None yet
Development

Successfully merging this pull request may close these issues.