-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle certain empty subfiling environment variables #4038
Merged
Merged
Changes from 21 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
74573e7
Handle certain subfiling environment variables that are not set to an…
9659199
Fix all subfiling environment variables
69112cd
Committing clang-format changes
github-actions[bot] 2a3d6f1
Update for Jordan's comments
110ab36
Fix conflict
88c5e94
Committing clang-format changes
github-actions[bot] 08e6cf5
Passes all tests
8770bc6
Merge branch 'github_3978' of https://github.com/glennsong09/hdf5 int…
b768e0e
Make Jordan's changes
abf4d99
Committing clang-format changes
github-actions[bot] 653f3d0
Test empty subfiling environment variables
bb26dfa
Committing clang-format changes
github-actions[bot] ea17485
Add test case for t_vfd
03d6798
Committing clang-format changes
github-actions[bot] 4dd9238
Fixes
e49c046
Merge branch 'github_3978' of https://github.com/glennsong09/hdf5 int…
a596187
Committing clang-format changes
github-actions[bot] ee7bb78
Fixes
b3389aa
Merge branch 'github_3978' of https://github.com/glennsong09/hdf5 int…
dd5c687
Committing clang-format changes
github-actions[bot] 62e71a6
Fix for Quincey/Jordan
10c6aaf
Committing clang-format changes
github-actions[bot] ccd9299
Remove saving env var code
8971492
Merge branch 'github_3978' of https://github.com/glennsong09/hdf5 int…
329ba12
Committing clang-format changes
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same fix here? (Either not saving the values or strdup'ing them)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think saving the values is necessary? I wasn't sure. If you don't think so, I can just remove it there too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the time being, we don't really need to save the values since this is the last set of tests that run. If another set of tests is interested in the values from the environment in the future we may need to save the values, but otherwise it's fine to remove them for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I can remove it from this test too.