Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated vlen release in ttsafe test #4863

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Replace deprecated vlen release in ttsafe test #4863

merged 1 commit into from
Sep 23, 2024
+1 −1

Conversation

mattjala
Copy link
Contributor

No description provided.

@mattjala mattjala added Merge - Develop Only This cannot be merged to previous versions of HDF5 (file format or breaking API changes) Priority - 2. Medium ⏹ It would be nice to have this in the next release Component - C Library Core C library issues (usually in the src directory) Type - Bug Please report security issues to [email protected] instead of creating an issue on GitHub labels Sep 20, 2024
@mattjala mattjala self-assigned this Sep 20, 2024
@qkoziol
Copy link
Contributor

qkoziol commented Sep 20, 2024

As you mentioned, this header should already be getting included, so I have a feeling this is not the solution. I'll look at it today and see if I can learn more.

@qkoziol
Copy link
Contributor

qkoziol commented Sep 20, 2024

Found the problem: H5Dvlen_reclaim is deprecated in favor of H5Treclaim. So, the code in ttsafe_attr_vlen.c should use the new routine. (And doesn't need any additional headers)

@mattjala mattjala changed the title Fix missing declaration in MacOS ttsafe test Replace deprecated vlen release in ttsafe test Sep 20, 2024
@lrknox lrknox merged commit 39fdf5d into HDFGroup:develop Sep 23, 2024
56 checks passed
@mattjala mattjala deleted the ttsafe_include_h5d branch September 23, 2024 20:11
qkoziol pushed a commit to qkoziol/hdf5 that referenced this pull request Oct 1, 2024
@mattjala @qkoziol
Fix missing routine on MacOS ttsafe test (HDFGroup#4863)
287c78f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyoklee hyoklee hyoklee approved these changes

@qkoziol qkoziol qkoziol approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@byrnHDF byrnHDF Awaiting requested review from byrnHDF byrnHDF is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees

@mattjala mattjala

Labels
Component - C Library Core C library issues (usually in the src directory) Merge - Develop Only This cannot be merged to previous versions of HDF5 (file format or breaking API changes) Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Bug Please report security issues to [email protected] instead of creating an issue on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattjala @qkoziol @hyoklee @lrknox