Add workflow that reports to CDash #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Merge - To 1.14
mattjala
reviewed
Sep 25, 2024
mattjala
reviewed
Sep 25, 2024
mattjala
reviewed
Sep 25, 2024
mattjala
reviewed
Sep 25, 2024
mattjala
reviewed
Sep 25, 2024
mattjala
reviewed
Sep 25, 2024
mattjala
reviewed
Sep 25, 2024
mattjala
reviewed
Sep 25, 2024
| set (CTEST_SITE "${HOSTNAME}${CTEST_SITE_EXT}") | ||
| #find_program (HOSTNAME_CMD NAMES hostname) | ||
| #execute_process (COMMAND ${HOSTNAME_CMD} OUTPUT_VARIABLE HOSTNAME OUTPUT_STRIP_TRAILING_WHITESPACE) | ||
| #set (CTEST_SITE "${HOSTNAME}${CTEST_SITE_EXT}") |
There was a problem hiding this comment.
Comment should be removed unless there's a specific reason to keep this around
There was a problem hiding this comment.
Allen's not sure whether or not this change will be permanent.
mattjala
reviewed
Sep 25, 2024
| set (CTEST_SITE "${HOSTNAME}${CTEST_SITE_EXT}") | ||
| #find_program (HOSTNAME_CMD NAMES hostname) | ||
| #execute_process (COMMAND ${HOSTNAME_CMD} OUTPUT_VARIABLE HOSTNAME OUTPUT_STRIP_TRAILING_WHITESPACE) | ||
| #set (CTEST_SITE "${HOSTNAME}${CTEST_SITE_EXT}") |
lrknox
approved these changes
Sep 25, 2024
hyoklee
reviewed
Sep 25, 2024
| @@ -468,8 +468,9 @@ jobs: | |||
| set (CTEST_DROP_SITE_INIT "my.cdash.org") | |||
| # Change following line to submit to your CDash dashboard to a different CDash project | |||
| #set (CTEST_DROP_LOCATION_INIT "/submit.php?project=HDF5") | |||
| #set (CMAKE_GENERATOR_TOOLSET "Intel C++ Compiler 2024,fortran=ifx") | |||
| set (CMAKE_GENERATOR_TOOLSET "Intel C++ Compiler 2024,fortran=ifx") | |||
There was a problem hiding this comment.
Why is fortran=ifx necessary?
See -DHDF5_BUILD_FORTRAN:BOOL=OFF in line 476.
There was a problem hiding this comment.
In the next PR when I fix Intel compiling I will enable fortran
hyoklee
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.