Remove H5E_clear_stack() from library #4871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use existing H5G_loc_exists() routine Signed-off-by: Quincey Koziol <[email protected]>
qkoziol
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
Signed-off-by: Quincey Koziol <[email protected]>
Signed-off-by: Quincey Koziol <[email protected]>
derobins
added
Merge - Develop Only
mattjala
approved these changes
Sep 24, 2024
| if (H5G_loc_find(&dst_root_loc, suggestion->path, &obj_loc /*out*/) < 0) | ||
| /* Ignore errors - i.e. suggestions not present in | ||
| * destination file */ | ||
| H5E_clear_stack(); |
There was a problem hiding this comment.
If you haven't already, it's worth documenting that developers should avoid calling H5E_clear_stack() in the library since I can easily see this cropping up again.
There was a problem hiding this comment.
Good point, I'll add that in the next PR.
jhendersonHDF
approved these changes
Sep 24, 2024
derobins
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use existing H5G_loc_exists() routine