Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hdf5_1_14_5 updates #4892

Merged
merged 6 commits into from
Sep 28, 2024
Merged

Hdf5_1_14_5 updates #4892

merged 6 commits into from
Sep 28, 2024

Conversation

lrknox
Copy link
Collaborator

@lrknox lrknox commented Sep 27, 2024

PR #4882
PR #4870

fortnern and others added 6 commits September 19, 2024 13:56
@fortnern @lrknox
Fix issues with large external data files (HDFGroup#4843) (HDFGroup#4847
1639ef8 
)
@lrknox
Merge branch 'hdf5_1_14_5' of https://github.com/HDFGroup/hdf5 into h…
2e678c2 
…df5_1_14_5_update
@bmribler @lrknox
Fixed a memory leak from H5FL_blk_malloc (HDFGroup#4882)
d9b4a95 
In H5F__accum_reset(), when H5F__accum_flush() failed, the freeing of
f_sh->accum.buf was never reached, causing resource leak.

@fortnern added the third argument to H5F__accum_reset() so we can free
f_sh->accum.buf when we close the file, that is, when H5F__accum_reset()
is called from the H5F__dest() route, and can leave the accumulator in place
otherwise.
@bmribler @lrknox
Added an entry for the HDFGroupGH-4585 fix (HDFGroup#4889)
314f8f5
@bmribler @lrknox
Fix an incorrect returned value by H5LTfind_dataset() (HDFGroup#4869)
752dda3 
H5LTfind_dataset() returns true for non-existing datasets because it only compares up to the length of the searched string, such as "Day" vs "DayNight" (issue HDFGroupGH-4780).

This PR applied the user's patch and added tests.
@bmribler @lrknox
Fix minor spelling in documentation (HDFGroup#4870)
a3d4ba3
@lrknox lrknox merged commit cb13cf2 into HDFGroup:hdf5_1_14_5 Sep 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendersonHDF jhendersonHDF jhendersonHDF approved these changes

@byrnHDF byrnHDF byrnHDF approved these changes

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lrknox @jhendersonHDF @byrnHDF @fortnern @bmribler