Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement BufferOrganizer triggers #440

Merged
merged 85 commits into from
Aug 25, 2022
Merged

Implement BufferOrganizer triggers #440

merged 85 commits into from
Aug 25, 2022

Conversation

ChristopherHogan
Copy link
Collaborator

Closes #326. See #326 for details.

@ChristopherHogan
Replace TraitIdArray with a vector since it doesn't have to live in s…
4ba6aea 
…hared memory
@ChristopherHogan
Add WriteOnlyTrait and test [skip ci]
4fc7835
@ChristopherHogan
Fix warning
b25e8ce
@ChristopherHogan
Fix unused variable warning
d470813
@ChristopherHogan
TestWriteOnly BORG test working
15c938d
@ChristopherHogan
Add ReadOnlyTrait and test
e0fad8e
@ChristopherHogan
Try to fix undefined symbol that can't be reproduced locally
8c92f1c
@ChristopherHogan
Add config variables for BO min/max capacity thresholds
f4896f6
@ChristopherHogan
Groundwork for read/write BORG trigger
c888df4
@ChristopherHogan
Remove ReadOnlyTrait
6745869
@ChristopherHogan
Remove unused define
2aae73d
@ChristopherHogan
Allow passing options to placement algorithms
a467bbe
@ChristopherHogan
Initial BORG benchmark
a57ab3b
@ChristopherHogan
Basic write only BORG benchmark running
5477e06
@ChristopherHogan
Appease linter
f293a60
@ChristopherHogan
WIP
fa5323d
@ChristopherHogan
Appease linter
bc0ef4e
@ChristopherHogan
Remove default context arg from MinimizeIoTimePlacement
f015dc3
@ChristopherHogan
Fix deadlock in buffer_organizer_test
baec9d6
@ChristopherHogan
Make capacity thresholds a percentage
4cd7439
@ChristopherHogan
Placeholders
ff2e68b
@ChristopherHogan
Fix compilation error
5952757
@ChristopherHogan
Remove debugging code from borg_bench.cc
6800712
@ChristopherHogan
Always subtract 1 in GetHostNumberAsString
d0c4f8b
@ChristopherHogan
Only call onUnlink for valid blobs
79bfd2c
@ChristopherHogan
Fix case where rpc_host_number_range is empty
486000a
@ChristopherHogan
Add missing check in for loop
09fe08a
@ChristopherHogan
All ranks must get RpcContext::num_host_numbers
eb6b3bd
@ChristopherHogan
Blob name in verbose BORG logging
d1294fc
@ChristopherHogan
Check for NULL BucketInfo
d5db940
@ChristopherHogan
[skip ci] WIP: selecting Targets and Buffers to move
80936f5
@ChristopherHogan
Initial BORG implementation complete
cf1d10b
@ChristopherHogan
Fix BORG bugs and add mixed workload test
a6becfe
@ChristopherHogan
Handle kMin case in EnforceCapacityThresholds
cd1d8ed
@ChristopherHogan
BORG min violation working with test
e5b85ca
@ChristopherHogan
Reorganize borg_bench in preperation for mixed workload
0e5d0a2
@ChristopherHogan
Adding Mixed BORG benchmark
ab119ec
@ChristopherHogan
BORG read benchmark basics
00e2ba5
@ChristopherHogan
Optimized-read BORG bench complete
4a4a251
@ChristopherHogan
Fix bug in DPE
acdfd56
@ChristopherHogan
Fix new warnings revealed by updated compiler
88fa305
@ChristopherHogan
Expose GetIdsPtr for testing
5ba703c
@ChristopherHogan
Use VLOG for DPE logging
0e0a3af
@ChristopherHogan
Clear memory on heap free
f419848
@ChristopherHogan
Refactor to avoid long names
fd3325a
@ChristopherHogan
WIP: Fixing LocalEnforceCapacityThresholds
473f745
@ChristopherHogan
Fix scope of buffers_to_move
b088c55
@ChristopherHogan
Use bytes_read instead of kTotalBytes
fbd1333
@ChristopherHogan
Only read the number of blobs that fit in the first 2 tiers
61d636b
@ChristopherHogan
Pass sleep on cli
c1ba0ce
@ChristopherHogan
Seconds -> milliseconds
61ceeab
@ChristopherHogan
Skip low_buf test for now.
ec47df7
@ChristopherHogan
Cleanup before PR
d8ed4c2
@ChristopherHogan ChristopherHogan self-assigned this Aug 24, 2022
@ChristopherHogan ChristopherHogan added the enhancement New feature or request label Aug 24, 2022
@coveralls
Copy link

coveralls commented Aug 24, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 81.255% when pulling 5f3e951 on chogan/borg_triggers into 412c2f6 on master.

@ChristopherHogan ChristopherHogan merged commit 0300696 into master Aug 25, 2022
@ChristopherHogan ChristopherHogan deleted the chogan/borg_triggers branch August 25, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ChristopherHogan ChristopherHogan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement BORG triggers
2 participants
@ChristopherHogan @coveralls