Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: redundant "lib" #28

Closed
kmilos opened this issue Sep 25, 2024 · 2 comments
Closed

CMake: redundant "lib" #28

kmilos opened this issue Sep 25, 2024 · 2 comments

Comments

@kmilos
Copy link
Contributor

kmilos commented Sep 25, 2024

Since 4.5.0 there is a redundant "lib" directory created when installing some artifacts:

/lib/lib/cfitsio-4.5.0/
/lib/lib/cfitsio-4.5.0/cfitsio-config.cmake
/lib/lib/cfitsio-4.5.0/cfitsio-config-version.cmake
/lib/lib/pkgconfig/
/lib/lib/pkgconfig/cfitsio.pc

This seems to be regression introduced in 29eccbb trying to address #23.

Edit: Arch workaround, Fedora patch...

@kmilos
Copy link
Contributor Author

kmilos commented Sep 25, 2024

Btw, there's seldom need to override and construct LIB_DESTINATION (and other install dirs) by hand like that.

GNUInstallDirs CMAKE_INSTALL_LIBDIR (and others) should be correct (almost) all the time, even on multi-arch systems.

@bryanirby
Copy link
Collaborator

Hi @kmilos, thanks for the report. I've checked a fix for this into the develop branch. We'll look into revising the use of LIB_DESTINATION et al. in future development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants