Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfitsio: update to 4.5.0 #22036

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

cfitsio: update to 4.5.0 #22036

wants to merge 5 commits into from

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Sep 25, 2024

Will need all deps rebuilt because of soname change:

mingw-w64-ucrt-x86_64-gdal
mingw-w64-ucrt-x86_64-gimp3
mingw-w64-ucrt-x86_64-libvips
mingw-w64-ucrt-x86_64-python-imagecodecs

@kmilos kmilos marked this pull request as draft September 25, 2024 12:26
@kmilos
Copy link
Contributor Author

kmilos commented Sep 25, 2024

Hm, also need to remove the redundant "lib/"...

@ognevny
Copy link
Collaborator

ognevny commented Sep 25, 2024

Hm, also need to remove the redundant "lib/"...

-DCMAKE_INSTALL_LIBDIR can't be set?

@kmilos
Copy link
Contributor Author

kmilos commented Sep 25, 2024

-DCMAKE_INSTALL_LIBDIR can't be set?

No, it affects only the cmake and pkgconf files, not the actual libs...

It's an upstream regression.

Edit: looks like Arch patched this already, using the same here...

@kmilos kmilos marked this pull request as ready for review September 25, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants