Add support for compiling with newer ONNXRuntime #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least version 1.17.1 (this is the most recent one in spack) provides onnxruntimeConfig.cmake and uses the name "onnxruntime" all lower case. This PR should make it possible to build with 1.17.1 (waiting for confirmation if the stack builds) and with the current ONNXRuntime version (CI seems to confirm this)
Related to this, it seems newer versions of ONNXRuntime don't install the headers that are being used by FCCAnalyses (everything under
include/onnxruntime/coredoesn't get installed exceptcommon):FCCAnalyses/addons/ONNXRuntime/src/ONNXRuntime.cc
Line 3 in 994d52c
This seems to have changed from the version that was installed last time, which was 1.10.0. In that one, I can see the whole
corefolder being installed. For now I'm patchingONNXRuntimebut I didn't even find an option inONNXRuntimeto install these. Are these intended to be used then?See also key4hep/key4hep-spack#578