-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new component MDIReader #13
Conversation
Not ready yet, when running a test job for MDIReader I get the following error:
|
k4Gen/src/components/MDIReader.cpp
Outdated
StatusCode MDIReader::finalize() | ||
{ | ||
m_input.close(); | ||
std::cout<<"Fine di MDIreader"<<std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use gaudi logging instead of std::cout
std::cout<<"Fine di MDIreader"<<std::endl; | |
debug() << "Finalization of MDIREADER" << endmsg; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I changed also the other std::cout
to debug()
k4Gen/src/components/MDIReader.h
Outdated
|
||
#include "GaudiKernel/SystemOfUnits.h" | ||
|
||
#include "HepMC/IO_GenEvent.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use HepMC3 here (see https://github.com/HEP-FCC/k4Gen/blob/main/k4Gen/src/components/HepMCFileReader.h)
Please also add an example options file and test, like here: https://github.com/HEP-FCC/k4Gen/blob/main/k4Gen/CMakeLists.txt#L49 |
I think it should be ok now. Please let me know if this request can be accepted or if I have to do other modifications. |
Yes, looks good. I'd like to split the CMake changes from this PR and properly add the RPATH changes to this repo, I'll take care of that and merge this afterwards. |
Hi @aciarma, I took the liberty of rebasing this onto the RPATH changes in master and added a quick fix. But I have a couple of questions more:
|
Removed the Geant4 call from the example and verified that the job options work correctly (even if not declared as Gaudi::Property). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you very much!
Added MDIReader, to use as input ascii files containing lists of particles.
Formats supported at the moment: