Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get particle spin/helicity from attribute 'spin', if any #15

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Conversation

gganis
Copy link
Member

@gganis gganis commented Aug 18, 2022

This patch honours an HepMC3 particle attribute name 'spin' and fills the corresponding member in edm4hep::MCParticle .

@gganis gganis added the enhancement New feature or request label Aug 18, 2022
Copy link
Member

@vvolkl vvolkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@vvolkl vvolkl merged commit 75a7a53 into main Aug 18, 2022
@vvolkl vvolkl deleted the fillspin branch August 18, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants