Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use GaudiAlg #37

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Do not use GaudiAlg #37

merged 6 commits into from
Jul 30, 2024

Conversation

jmcarcell
Copy link
Contributor

These are the changes needed not to use GaudiAlg, which will be removed (maybe soon) in Gaudi.

Changes:

  • Do not link to GaudiAlgLib
  • Add the necessary changes to the algorithm, use Gaudi::Algorithm, make execute() const and add a const EventContext&
  • Add mutable to some elements that are changed; add const to some functions so that they can be called inside execute(const EventContext&) const
  • Change GaudiTool to AlgTool

@jmcarcell
Copy link
Contributor Author

To be able to keep building the nightlies with Gaudi without GaudiAlg a review here would be nice @BrieucF or @kjvbrt.

@kjvbrt
Copy link
Contributor

kjvbrt commented Jul 30, 2024

Thank you @jmcarcell :)

@kjvbrt kjvbrt merged commit 751146a into HEP-FCC:main Jul 30, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants