Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to HepMC3 #9

Merged
merged 6 commits into from
Nov 20, 2021
Merged

Upgrade to HepMC3 #9

merged 6 commits into from
Nov 20, 2021

Conversation

vvolkl
Copy link
Member

@vvolkl vvolkl commented Nov 18, 2021

This PR applies the necessary changes to use HepMC3 instead of HepMC2. See

http://hepmc.web.cern.ch/hepmc/differences.html

for details. The previous HepMCFile{Reader|Writer} has been renamed to HepMC2File{Reader|Writer}, and HepMCFile{Reader|Writer} now reads|writes in HepMC3 format.

This should not be a breaking change for existing job configurations, except when HepMC2 files are read or written, in which case the new tools should be used (or the file format should be updated).

@vvolkl vvolkl requested a review from gganis November 18, 2021 17:19
Copy link
Member

@gganis gganis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me at first. I see that you took the opportunity for modernizing some loops.

@vvolkl vvolkl merged commit dd2489a into main Nov 20, 2021
@vvolkl vvolkl deleted the hepmc3 branch November 20, 2021 13:25
@vvolkl vvolkl mentioned this pull request Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants