Avoid list comprehension (#45)

HEP-FCC · Aug 11, 2023 · c603544 · c603544
1 parent 1aacc5a
commit c603544
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 20 deletions.
diff --git a/RecFCCeeCalorimeter/tests/options/fcc_ee_caloBenchmarkCalibration.py b/RecFCCeeCalorimeter/tests/options/fcc_ee_caloBenchmarkCalibration.py
@@ -24,7 +24,8 @@
 DETECTORS = [
     'Detector/DetFCCeeIDEA-LAr/compact/FCCee_DectMaster.xml',
 ]
-GEOSERVICE.detectors = [os.path.join(DETECTORPATH, d) for d in DETECTORS]
+for det in DETECTORS:
+    GEOSERVICE.detectors = [os.path.join(DETECTORPATH, det)]
 GEOSERVICE.OutputLevel = INFO
 ApplicationMgr().ExtSvc += [GEOSERVICE]
 

diff --git a/RecFCCeeCalorimeter/tests/options/reproduceSegfault.py b/RecFCCeeCalorimeter/tests/options/reproduceSegfault.py
@@ -60,13 +60,13 @@
 from Configurables import GeoSvc
 geoservice = GeoSvc("GeoSvc")
 # if FCC_DETECTORS is empty, this should use relative path to working directory
-path_to_detector = os.environ.get("FCCDETECTORS", "")
-print(path_to_detector)
-detectors_to_use=[
-                    'Detector/DetFCCeeIDEA-LAr/compact/FCCee_DectMaster.xml',
-                  ]
-# prefix all xmls with path_to_detector
-geoservice.detectors = [os.path.join(path_to_detector, _det) for _det in detectors_to_use]
+path_to_detectors = os.environ.get("FCCDETECTORS", "")
+detectors = [
+    'Detector/DetFCCeeIDEA-LAr/compact/FCCee_DectMaster.xml',
+]
+# prefix all xmls with path_to_detectors
+for det in detectors:
+    geoservice.detectors += [os.path.join(path_to_detectors, det)]
 geoservice.OutputLevel = INFO
 
 # Geant4 service

diff --git a/RecFCCeeCalorimeter/tests/options/runCaloSim.py b/RecFCCeeCalorimeter/tests/options/runCaloSim.py
@@ -46,12 +46,13 @@
 from Configurables import GeoSvc
 geoservice = GeoSvc("GeoSvc")
 # if FCC_DETECTORS is empty, this should use relative path to working directory
-path_to_detector = os.environ.get("FCCDETECTORS", "")
-detectors_to_use=[
-                    'Detector/DetFCCeeIDEA-LAr/compact/FCCee_DectMaster.xml',
-                  ]
-# prefix all xmls with path_to_detector
-geoservice.detectors = [os.path.join(path_to_detector, _det) for _det in detectors_to_use]
+path_to_detectors = os.environ.get("FCCDETECTORS", "")
+detectors = [
+    'Detector/DetFCCeeIDEA-LAr/compact/FCCee_DectMaster.xml',
+]
+# prefix all xmls with path_to_detectors
+for det in detectors:
+    geoservice.detectors += [os.path.join(path_to_detectors, det)]
 geoservice.OutputLevel = INFO
 ApplicationMgr().ExtSvc += [geoservice]
 

diff --git a/RecFCCeeCalorimeter/tests/options/runFullCaloSystem_ReconstructionSW_noiseFromFile.py b/RecFCCeeCalorimeter/tests/options/runFullCaloSystem_ReconstructionSW_noiseFromFile.py
@@ -1,3 +1,4 @@
+import os
 # Setup
 # Names of cells collections
 ecalBarrelCellsName = "ECalBarrelCells"
@@ -22,12 +23,13 @@
 from Configurables import GeoSvc
 geoservice = GeoSvc("GeoSvc")
 # if FCC_DETECTORS is empty, this should use relative path to working directory
-path_to_detector = os.environ.get("FCCDETECTORS", "")
-detectors_to_use=[
-                    'Detector/DetFCCeeIDEA-LAr/compact/FCCee_DectMaster.xml'
-                  ]
-# prefix all xmls with path_to_detector
-geoservice.detectors = [os.path.join(path_to_detector, _det) for _det in detectors_to_use]
+path_to_detectors = os.environ.get("FCCDETECTORS", "")
+detectors = [
+    'Detector/DetFCCeeIDEA-LAr/compact/FCCee_DectMaster.xml'
+]
+# prefix all xmls with path_to_detectors
+for det in detectors:
+    geoservice.detectors = [os.path.join(path_to_detectors, det)]
 geoservice.OutputLevel = WARNING